[PATCH v2 3/4] riscv: dts: spacemit: k1-bananapi-f3: Correct USB hub power hierarchy

[Anand Moon]

Hi Chukun,

Thanks for your  review comments.

On Thu, 7 May 2026 at 12:20, Chukun Pan <amadeus at jmu.edu.cn> wrote:
>
> Hi,
>
> >       usb3_hub_5v: regulator-usb3-hub-5v {
> >               compatible = "regulator-fixed";
> > -             regulator-name = "USB30_HUB";
> > +             regulator-name = "VCC5V0_HUB";
>
> Suggested changes:
>         vcc5v0_hub: regulator-vcc5v0-hub {
>                 compatible = "regulator-fixed";
>                 regulator-name = "vcc5v0_hub";
>
Ok will update this if there is a positive response.
> >               regulator-min-microvolt = <5000000>;
> >               regulator-max-microvolt = <5000000>;
> > +             regulator-always-on;
>
> Why always on?
The driver side does not manage enabling / disabling this regulator.
>
> > @@ -361,6 +362,7 @@ &usb_dwc3 {
> >       dr_mode = "host";
> >       #address-cells = <1>;
> >       #size-cells = <0>;
> > +     vbus-supply = <&usb3_hub_5v>;
> >       status = "okay";
>
> This is incorrect. See the previous reply.

I replied in the previous email.

Thanks
-Anand