[RFC v1 3/4] pinctrl: spacemit: delete check_power()
Conor Dooley
conor at kernel.org
Wed May 6 02:57:41 PDT 2026
From: Conor Dooley <conor.dooley at microchip.com>
AFAICT, this is pointless because generate_config performs this check
too.
Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
---
drivers/pinctrl/spacemit/pinctrl-k1.c | 37 ---------------------------
1 file changed, 37 deletions(-)
diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
index 62cab6f6cd0a8..41d8a34bc386b 100644
--- a/drivers/pinctrl/spacemit/pinctrl-k1.c
+++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
@@ -409,38 +409,6 @@ static inline u32 spacemit_get_drive_strength_mA(enum spacemit_pin_io_type type,
}
}
-static int spacemit_pctrl_check_power(struct pinctrl_dev *pctldev,
- struct device_node *dn,
- struct spacemit_pin_mux_config *pinmuxs,
- int num_pins, const char *grpname)
-{
- struct spacemit_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
- struct device *dev = pctrl->dev;
- enum spacemit_pin_io_type type;
- u32 power = 0, i;
-
- of_property_read_u32(dn, "power-source", &power);
-
- for (i = 0; i < num_pins; i++) {
- type = spacemit_to_pin_io_type(pinmuxs[i].pin);
-
- if (type != IO_TYPE_EXTERNAL)
- continue;
-
- switch (power) {
- case PIN_POWER_STATE_1V8:
- case PIN_POWER_STATE_3V3:
- break;
- default:
- dev_err(dev, "group %s has unsupported power\n",
- grpname);
- return -ENOTSUPP;
- }
- }
-
- return 0;
-}
-
static void spacemit_set_io_pwr_domain(struct spacemit_pinctrl *pctrl,
const struct spacemit_pin *spin,
const enum spacemit_pin_io_type type)
@@ -548,11 +516,6 @@ static int spacemit_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
return dev_err_probe(dev, -ENODEV, "failed to get pin %d\n", pins[i]);
}
- ret = spacemit_pctrl_check_power(pctldev, child, pinmuxs,
- npins, grpname);
- if (ret < 0)
- return ret;
-
map[nmaps].type = PIN_MAP_TYPE_MUX_GROUP;
map[nmaps].data.mux.function = np->name;
map[nmaps].data.mux.group = grpname;
--
2.53.0
More information about the linux-riscv
mailing list