[PATCH v2 7/7] riscv: dts: tenstorrent: Add Atlantis platform
Conor Dooley
conor at kernel.org
Fri Jun 5 08:41:20 PDT 2026
On Sat, Jun 06, 2026 at 12:02:41AM +1000, Michael Ellerman wrote:
> On 5/6/26 2:47 am, Conor Dooley wrote:
> > On Fri, Jun 05, 2026 at 12:09:53AM +0930, Joel Stanley wrote:
> > > Add initial support for the Tenstorrent Atlantis platform, based on the
> > > Atlantis SoC featuring 8x RVA23-compliant Tenstorrent Ascalon-XG cores.
> > >
> > > The evb machine represents an internal bringup vehicle with just the
> > > interrupt controllers and a UART. This will be replaced in time with a
> > > full featured machine once details are available.
> ...
> > > diff --git a/arch/riscv/boot/dts/tenstorrent/atlantis-evb.dts b/arch/riscv/boot/dts/tenstorrent/atlantis-evb.dts
> > > new file mode 100644
> > > index 000000000000..06259cca8357
> > > --- /dev/null
> > > +++ b/arch/riscv/boot/dts/tenstorrent/atlantis-evb.dts
> > > @@ -0,0 +1,33 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > +/dts-v1/;
> > > +
> > > +#include "atlantis-soc.dtsi"
> > > +
> > > +/ {
> > > + model = "Tenstorrent Atlantis development platform";
> > > + compatible = "tenstorrent,atlantis-evb", "tenstorrent,atlantis";
> > > +
> > > + #address-cells = <2>;
> > > + #size-cells = <2>;
> > > +
> > > + memory at 0 {
> > > + device_type = "memory";
> > > + reg = <0x0 0x00000000 0x0 0x80000000>,
> > > + <0x1 0x80000000 0x0 0x80000000>;
> > > + };
> > > +
> > > + aliases {
> > > + serial0 = &uart1;
> > > + };
> > > +
> > > + chosen {
> > > + bootargs = "earlycon console=ttyS0";
> >
> > FYI, this should not be in here.
>
> It should be there if you want a working console :)
>
> I know it's a "rule" to not include bootargs, but this system has no boot
> loader, so not setting bootargs just means the DTS is no use to anyone.
I see! Could you note this please in the commit message?
>
> > > + stdout-path = "serial0";
> > > + };
> > > +};
> > > +
> > > +&uart1 {
> > > + /delete-property/ clocks;
> >
> > Why are you doing this? Looks kinda suspect!
>
> On the bringup system the uart has a fixed clock, I don't know exactly why.
The reason I ask is less about the rate being fixed, and more why you
need to set it like this. You've got
clocks = <&prcm_rcpu CLK_UART1_PCLK>;
and I would expect (or maybe more accurately hope) that the prcm_rcpu
driver would be able to report the fixed rate?
>
> > > + clock-frequency = <5000000>;
> > > + status = "okay";
> > > +};
> Having said that, I think we talked about making this DTS match the qemu
> model rather than the internal bringup system. So if we do that then this
> will change.
>
> Thanks for the reviews.
>
> cheers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20260605/1d8e70fa/attachment.sig>
More information about the linux-riscv
mailing list