[PATCH 03/83] ASoC: codecs: idt821034: don't use array if single pattarn
Herve Codina
herve.codina at bootlin.com
Wed Jun 3 05:11:47 PDT 2026
Hi Kuninori,
On Tue, 26 May 2026 01:58:59 +0000
Kuninori Morimoto <kuninori.morimoto.gx at renesas.com> wrote:
> Because it is confusable during debugging ASoC FW update, tidyup
> auto format style not to use array if single pattern case.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> ---
> sound/soc/codecs/idt821034.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/idt821034.c b/sound/soc/codecs/idt821034.c
> index 39bafefa6a186..084090ccef77a 100644
> --- a/sound/soc/codecs/idt821034.c
> +++ b/sound/soc/codecs/idt821034.c
> @@ -860,18 +860,17 @@ static int idt821034_dai_startup(struct snd_pcm_substream *substream,
> return 0;
> }
>
> -static const u64 idt821034_dai_formats[] = {
> +static const u64 idt821034_dai_formats =
> SND_SOC_POSSIBLE_DAIFMT_DSP_A |
> - SND_SOC_POSSIBLE_DAIFMT_DSP_B,
> -};
> + SND_SOC_POSSIBLE_DAIFMT_DSP_B;
>
> static const struct snd_soc_dai_ops idt821034_dai_ops = {
> .startup = idt821034_dai_startup,
> .hw_params = idt821034_dai_hw_params,
> .set_tdm_slot = idt821034_dai_set_tdm_slot,
> .set_fmt = idt821034_dai_set_fmt,
> - .auto_selectable_formats = idt821034_dai_formats,
> - .num_auto_selectable_formats = ARRAY_SIZE(idt821034_dai_formats),
> + .auto_selectable_formats = &idt821034_dai_formats,
> + .num_auto_selectable_formats = 1,
> };
>
> static struct snd_soc_dai_driver idt821034_dai_driver = {
Same typo in the commit title as in patch 2:
s/pattarn/pattern/
Or even
s/pattarn/item/
With that fixed,
Reviewed-by: Herve Codina <herve.codina at bootlin.com>
Best regards,
Hervé
More information about the linux-riscv
mailing list