[PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu
Baihui Liang
liangbaihui at linux.spacemit.com
Wed Jul 29 03:04:41 PDT 2026
On Wed Jul 29, 2026 at 5:16 PM CST, Krzysztof Kozlowski wrote:
> On 29/07/2026 11:14, Baihui Liang wrote:
> > On Wed Jul 29, 2026 at 3:57 PM CST, Krzysztof Kozlowski wrote:
> >> On 29/07/2026 09:46, Baihui Liang wrote:
> >>> On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote:
> >>> > > [...]
> >>> > > spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p-gpu/
> >>> > > ti,j721s2-gpu "if" block that restricts clocks to a single entry,
> >>> > > since K3 has the same single-clock requirement. It does not match any
> >>> > > "if" block that constrains power-domains, so that property falls back
> >>> >
> >>> > I don't get this explanation. Are you explaining what the patch is doing
> >>> > or explaining WHY you did this that way?
> >>>
> >>>
> >>> That paragraph was describing schema mechanics, which does not belong in
> >>> a commit message. v4 will drop it and state only the hardware facts: the
> >>> K3 integration of the BXM-4-64 has a single "core" clock, and it has no
> >>> software-controllable GPU power domain.
> >>>
> >>>
> >>> > > to this schema's general constraints, where it is optional. This
> >>> > > leaves room for a power-domains provider to be added later without a
> >>> > > further binding change, should one ever be modelled in Linux for this
> >>> > > SoC.
> >>> >
> >>> > No, you need to provide constraints now. Please read carefully
> >>> > writing-bindings.
> >>>
> >>>
> >>> Understood. spacemit,k3-gpu currently matches no power-domains "if"
> >>> block, so it falls back to the top-level 1-2 domains with
> >>> power-domain-names "a"/"b". That would let a K3 DT with two power
> >>> domains pass validation, which does not describe this hardware. v4 will
> >>> add an explicit "if" block:
> >>>
> >>>
> >>> - if:
> >>> properties:
> >>> compatible:
> >>> contains:
> >>> const: spacemit,k3-gpu
> >>> then:
> >>> properties:
> >>> power-domains: false
> >>> power-domain-names: false
> >>
> >> I understand only half of this. Please fix your email client.
> >>
> >> And why this reply misses reply-to header which connects it to proper
> >> thread? How am I supposed to find the thread now, among 200 I received
> >> yesterday?
> >
> > Sorry -- that went out through a webmail client which sent HTML, so the
> > quoting and the YAML indentation were destroyed, and it composed a new
> > message instead of replying in place, which is why it lost the thread.
> > I have switched to git send-email over our own SMTP; this reply should
> > be plain text and properly threaded.
> >
> >> So your name is presented here as "Baihui Liang" then why do you use
> >> some fake company name?
> >
> > liangbaihui at linux.spacemit.com is my real work address at SpacemiT. It is
> > now sent through the company's own mail server.
>
> Again: then why do you use fake company name as name? Actually not a
> company name, but laminated product of some company?
>
> What is Sterling-Ash?
>
> Best regards,
> Krzysztof
Sorry, I misread what you were asking and answered the wrong question.
"Sterling-Ash" is not a company and not a product name. It was a
personal nickname left over in my git config, and I did not notice it
was being used as the author name on the patches until you asked. It is
not my name and should not have appeared there.
The git config is fixed, and v4 will be sent with:
From: Baihui Liang <liangbaihui at linux.spacemit.com>
Signed-off-by: Baihui Liang <liangbaihui at linux.spacemit.com>
Best regards,
Baihui Liang
More information about the linux-riscv
mailing list