[PATCH v3 1/2] dt-bindings: arm: coresight-ctcu: document CTCU device for shikra
Jie Gan
jie.gan at oss.qualcomm.com
Wed Jul 22 03:56:47 PDT 2026
On 7/22/2026 4:15 PM, Krzysztof Kozlowski wrote:
> On Wed, Jul 22, 2026 at 09:13:47AM +0800, Jie Gan wrote:
>> The CTCU device for shikra shares the same configurations as SA8775p.
>> Add a fallback to enable the CTCU for shikra to utilize the compatible
>> of the SA8775p.
>>
>
> This is not arm,coresight-ctcu. This is qcom,coresight-ctcu, so the
> subject is:
> dt-bindings: arm: qcom,coresight-ctcu: add Shikra
>
> I already pointed out this problem at v2. Nothing in your subject is
> telling this is Qualcomm! Not even mentioning such trivial mistakes as
> lowercase shikra everywhere.
>
> I also do not understand why you add so much redundant information to
> subject. Subject space is precious.
>
> No, at this point you should not make such mistakes.
>
> Please take this feedback to your entire team, so I will not have to
> repeat the same exactly next time.
Thanks for comments. Will take care of it in future.
Jie
>
> Best regards,
> Krzysztof
>
More information about the linux-riscv
mailing list