Re: [PATCH v2 4/5] riscv: dts: thead: Add IO labels for the IO expansion on I2C1

[Icenowy Zheng]

于 2026年7月17日 GMT+08:00 04:52:19，Drew Fustini <fustini at kernel.org> 写道：
>On Tue, Jul 14, 2026 at 03:45:14PM +0800, Icenowy Zheng wrote:
>> From: Emil Renner Berthing <emil.renner.berthing at canonical.com>
>> 
>> Add labels for GPIOs on the IO expansion chip on the I2C1 bus.
>> 
>> Signed-off-by: Emil Renner Berthing <emil.renner.berthing at canonical.com>
>> [Icenowy: Splitted off the patch adding all 3 IO expansions]
>> Signed-off-by: Icenowy Zheng <zhengxingda at iscas.ac.cn>
>> ---
>>  arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
>> index 74b120c6b063a..78f5979a56c14 100644
>> --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
>> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
>> @@ -128,6 +128,14 @@ ioexp2: gpio at 18 {
>>  		reg = <0x18>;
>>  		gpio-controller;
>>  		#gpio-cells = <2>;
>> +		gpio-line-names = "",
>> +				  "cam0_reset",
>> +				  "cam1_reset",
>> +				  "cam2_reset",
>> +				  "wl_host_wake",
>
>I am not sure the line name really matters all that, but it seems that
>pin 4 is also used as a reset gpio:

The "host" here is subject, which means "this pins is used by the host to wake the wl".

Maybe I should take the schematics name, "wl_host_wake_dev"? Or use another name on the page for Wi-Fi, "wl_reg_on"?

Thanks,
Icenowy

>
>  wifi_pwrseq: wifi-pwrseq {
>      compatible = "mmc-pwrseq-simple";
>      reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;
>      post-power-on-delay-ms = <200>;
>  };       
>
>Did you notice that too?
>
>Thanks,
>Drew