[PATCH 2/2] riscv: dts: spacemit: add fixed regulators for OrangePi

[Yixun Lan]

Hi Chunkun,

On 22:50 Fri 23 Jan     , Chukun Pan wrote:
> Hi,
> 
> > > +	pcie_vcc3v3: regulator-pcie-vcc3v3 {
> > can you follow the same name scheme with k1-bananapi-f3.dts?
> 
> Sorry, but I don't quite understand?
> 
> From fixed-regulator.yaml:
> properties:
>   $nodename:
>     anyOf:
>       - description: Preferred name is 'regulator-[0-9]v[0-9]'
>         pattern: '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'
>       - description: Any name allowed
>         deprecated: true
> 
> Using 'regulator-' as a prefix is correct.
> There are also some commits that changed regulator nodenames. [1]
Ok, good to know, then I'm fine with the prefix

> 
> As for the regulator-name, it should be consistent with the name in
> the schematics so that people can look it up between the two.
> The BPI-F3 also seems to have some names [2] that need improvement:
> 
> vcc_4v     -> vcc4v0_sys
> USB30_HUB  -> vcc5v0_hub
> USB30_VBUS -> 5v_vbus
> vin-supply    vcc5v0_sys
I do not have strong preference to have label/node name *strictly* matched
with the schematics, IMO, keeping certain alignment is ok, you can still
make some adjustment as long as keep it clean and explicit..
also it's still helpful to give a high level abstract name in 'regulator-name'
for the end user to know what's the regulator connect to.. e.g. in
 /sys/kernel/debug/regulator/regulator_summary

-- 
Yixun Lan (dlan)