[PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon display controllers

Icenowy Zheng uwu at icenowy.me
Wed Jan 21 23:06:14 PST 2026


在 2026-01-21星期三的 13:56 +0100,Thomas Zimmermann写道:

=============== 8< =================
> > +
> > +       if (irqs)
> > +               pr_warn("Unknown Verisilicon DC interrupt 0x%x
> > fired!\n", irqs);
> 
> I'd avoid pr_warn() here. This can fill your logs quickly.

Then is pr_warn_once() okay?

> 
> > +
> > +       return IRQ_HANDLED;
> > +}

=============== 8< =================

> > 
> > +       /* Fixup framebuffer address for src coordinates */
> > +       dma_addr += (state->src.x1 >> 16) * bpp;
> 
> bpp is deprecated and should be avoided in new code. You can compute
> the 
> offset with drm_format_min_pitch():
> 
> drm_format_min_pitch(fb->format, 0, state->src.x1 >> 16 )

Well it seems quite difficult to track what's deprecated in the DRM
subsystem, is there anything like a bulletin?


Thanks,
Icenowy



More information about the linux-riscv mailing list