[PATCH v4 3/4] phy: usb: Add driver for Canaan K230 USB 2.0 PHY

Jiayu Du jiayu.riscv at isrc.iscas.ac.cn
Wed Jan 21 05:55:10 PST 2026


On Wed, Jan 21, 2026 at 12:37:06PM +0530, Vinod Koul wrote:
> On 20-01-26, 22:32, Jiayu Du wrote:
> > + * Copyright (C) 2025 Jiayu Du <jiayu.riscv at isrc.iscas.ac.cn>
> 
> 2026 now!
> 
...
> > +	void __iomem *base = global->base;
> > +	u32 val;
> 
> blank line here please
> 
...
> > +    /* Configure test register (pull-ups/pull-downs) */
> 
> wrong alignment above, pls fix it

Thanks for pointing out these issues. I will fix them in v5.




More information about the linux-riscv mailing list