[PATCH 8/8] clk: tenstorrent: Add reset controller to Atlantis clock controller probe

Anirudh Srinivasan asrinivasan at oss.tenstorrent.com
Fri Jan 16 13:30:48 PST 2026


Hi Krzysztof,

On Fri, Jan 16, 2026 at 3:08 AM Krzysztof Kozlowski <krzk at kernel.org> wrote:
>
> Completely pointless. You do not have any user of this.
>
> Adding a few unused lines is not a logical change to the kernel. Why not
> adding it member by member like one patch for empty struct, then second
> patch for struct with adev, then third patch adding regmap?
>
>
> You just added this file! Why are you adding incomplete or even buggy
> code which immediately you fix?

Regarding your comments from patches 5, 6 and 8, I will clean up the
patches that add the auxdev and reset controller so that there are no
more unnecessary commits.



More information about the linux-riscv mailing list