Typo in pinctrl-th1520.c
Thomas Gerner
thomas.gerner at muenchen-mail.de
Wed Jan 14 07:20:17 PST 2026
Hello,
in the pincontrol file for the TH1520 SOC a pad is named wrong.
According to TH1520 System User Manual, chapter 3.2.1 (page 38) pad 8 in
pad group 3 is named QSPI0_D3_HOLD. With the wrong name QSPI1_D3_HOLD
one cannot select the right pad in a device tree because the name is not
unique. QSPI1_D3_HOLD is defined in pad group 2. This patch fixes the
the pad name.
diff --git a/drivers/pinctrl/pinctrl-th1520.c
b/drivers/pinctrl/pinctrl-th1520.c
index e641bad6728c..83e9c9f77370 100644
--- a/drivers/pinctrl/pinctrl-th1520.c
+++ b/drivers/pinctrl/pinctrl-th1520.c
@@ -287,7 +287,7 @@ static const struct pinctrl_pin_desc
th1520_group3_pins[] = {
TH1520_PAD(5, QSPI0_D0_MOSI, QSPI, PWM, I2S, GPIO, ____,
____, 0),
TH1520_PAD(6, QSPI0_D1_MISO, QSPI, PWM, I2S, GPIO, ____,
____, 0),
TH1520_PAD(7, QSPI0_D2_WP, QSPI, PWM, I2S, GPIO, ____,
____, 0),
- TH1520_PAD(8, QSPI1_D3_HOLD, QSPI, ____, I2S, GPIO, ____,
____, 0),
+ TH1520_PAD(8, QSPI0_D3_HOLD, QSPI, ____, I2S, GPIO, ____,
____, 0),
TH1520_PAD(9, I2C2_SCL, I2C, UART, ____, GPIO, ____,
____, 0),
TH1520_PAD(10, I2C2_SDA, I2C, UART, ____, GPIO, ____,
____, 0),
TH1520_PAD(11, I2C3_SCL, I2C, ____, ____, GPIO, ____,
____, 0),
---
Best regards
Thomas
More information about the linux-riscv
mailing list