[PATCH 2/5] lib/string_kunit: add test case for strnlen

Feng Jiang jiangfeng at kylinos.cn
Wed Jan 7 22:53:58 PST 2026


On 2026/1/7 19:56, Andy Shevchenko wrote:
> On Wed, Jan 7, 2026 at 4:35 AM Feng Jiang <jiangfeng at kylinos.cn> wrote:
>>
>> Add a KUnit test for strnlen() to verify correctness across
>> different string lengths and memory alignments.
> 
> Same comment as per patch 1 (it would probably require to call for
> arch_strnlen() or something like this).

Thanks, makes sense.

I'll add the performance benchmarking (random filling + timing) in V2.

Since string functions are typically exported directly by each architecture
without an arch_ prefix, I'll introduce a generic_strnlen() (based on
lib/string.c) within the test for comparison.

> ...
> 
>> +       for (offset = 0; offset < 16; offset++) {
>> +               for (len = 0; len <= 128; len++) {
> 
> You want to define these two limits to avoid the possible issues in
> the future if the code gets changed.

Got it, will define these limits as macros in V2. Thanks!

-- 
With Best Regards,
Feng Jiang




More information about the linux-riscv mailing list