[PATCH 1/2] dt-bindings: pinctrl: add syscon property
Troy Mitchell
troy.mitchell at linux.spacemit.com
Wed Jan 7 22:04:18 PST 2026
On Thu, Jan 01, 2026 at 11:54:02PM +0100, Linus Walleij wrote:
> Hi Troy,
>
> thanks for your patch!
>
> On Tue, Dec 23, 2025 at 10:11 AM Troy Mitchell
> <troy.mitchell at linux.spacemit.com> wrote:
>
> > + spacemit,apbc:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + items:
> > + - items:
> > + - description: phandle to syscon that access the protected register
> > + - description: offset of access secure registers
> (...)
> > + spacemit,apbc = <&syscon_apbc 0x50>;
>
> Isn't the offset implicit from the compatible of the pin controller or
> the syscon or any other compatible?
>
> It's easy to check compatibles in the device tree and just say
> this offset is 0x50 if compatible is so-or-so, and something else
> for another compatible and just give an error if an unknown
> compatible appears.
>
> So: please try to avoid to put things the code can easily look
> up into the device tree.
Thanks for you pointing it out. I'll remove it.
- Troy
>
> Yours,
> Linus Walleij
>
More information about the linux-riscv
mailing list