[PATCH v4 1/5] dt-bindings: soc: spacemit: k3: add clock support

[Krzysztof Kozlowski]

On Sat, Jan 03, 2026 at 03:44:16PM +0800, Yixun Lan wrote:
> Add compatible strings for clock drivers to support Spacemit K3 SoC,
> also includes all the defined clock IDs.
> 
> The SpacemiT K3 SoC clock IP is scattered over several different blocks,
> which are APBC, APBS, APMU, DCIU, MPMU, all of them are capable of
> generating clock and reset signals. APMU and MPMU have additional Power
> Domain management functionality.
> 
> Following is a brief list that shows devices managed in each block:
> 
> APBC: UART, GPIO, PWM, SPI, TIMER, I2S, IR, DR, TSEN, IPC, CAN
> APBS: various PPL clocks control
> APMU: CCI, CPU, CSI, ISP, LCD, USB, QSPI, DMA, VPU, GPU, DSI, PCIe, EMAC..
> DCID: SRAM, DMA, TCM
> MPMU: various PLL1 derived clocks, UART, WATCHDOG, I2S
> 
> Signed-off-by: Yixun Lan <dlan at gentoo.org>
> ---
>  .../devicetree/bindings/clock/spacemit,k1-pll.yaml |   8 +-
>  .../bindings/soc/spacemit/spacemit,k1-syscon.yaml  |  13 +-
>  include/dt-bindings/clock/spacemit,k3-clocks.h     | 390 +++++++++++++++++++++
>  3 files changed, 406 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml b/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml
> index 06bafd68c00a..66e109474824 100644
> --- a/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml
> +++ b/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml
> @@ -4,14 +4,16 @@
>  $id: http://devicetree.org/schemas/clock/spacemit,k1-pll.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: SpacemiT K1 PLL
> +title: SpacemiT K1/K3 PLL
>  
>  maintainers:
>    - Haylen Chu <heylenay at 4d2.org>
>  
>  properties:
>    compatible:
> -    const: spacemit,k1-pll
> +    enum:
> +      - spacemit,k1-pll
> +      - spacemit,k3-pll
>  
>    reg:
>      maxItems: 1
> @@ -28,7 +30,7 @@ properties:
>    "#clock-cells":
>      const: 1
>      description:
> -      See <dt-bindings/clock/spacemit,k1-syscon.h> for valid indices.
> +      See corresponding file under <dt-bindings/clock/> for valid indices.

List two paths, better. Generic path to clock directory is obvious and
not helping.

>  
>  required:
>    - compatible
> diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> index 133a391ee68c..66e6683a3ccb 100644
> --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/soc/spacemit/spacemit,k1-syscon.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: SpacemiT K1 SoC System Controller
> +title: SpacemiT K1/K3 SoC System Controller
>  
>  maintainers:
>    - Haylen Chu <heylenay at 4d2.org>
> @@ -22,6 +22,10 @@ properties:
>        - spacemit,k1-syscon-rcpu
>        - spacemit,k1-syscon-rcpu2
>        - spacemit,k1-syscon-apbc2
> +      - spacemit,k3-syscon-apbc
> +      - spacemit,k3-syscon-apmu
> +      - spacemit,k3-syscon-dciu
> +      - spacemit,k3-syscon-mpmu
>  
>    reg:
>      maxItems: 1
> @@ -39,7 +43,7 @@ properties:
>    "#clock-cells":
>      const: 1
>      description:
> -      See <dt-bindings/clock/spacemit,k1-syscon.h> for valid indices.
> +      See corresponding file under <dt-bindings/clock/> for valid indices.

Same problem here.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>

Best regards,
Krzysztof