[PATCH 08/12] dt-bindings: net: snps,dwmac: Add compatible for UltraRISC DP1000 SoC
Conor Dooley
conor at kernel.org
Mon Aug 24 10:09:48 PDT 2026
On Mon, Aug 24, 2026 at 01:54:21PM +0800, Jia Wang via B4 Relay wrote:
> From: Jia Wang <wangjia at ultrarisc.com>
>
> Add the SoC-specific compatible string for the UltraRISC DP1000 GMAC
> controller to the DesignWare MAC binding.
>
> Signed-off-by: Jia Wang <wangjia at ultrarisc.com>
The dts may not be right, but I am also a bit concerned here.
This binding permits 100s of combinations of properties, of which only
a very limited set can be correct for your device. Just adding the
compatible permits all of this variation.
Please add some restrictions.
pw-bot: changes-requested
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2449311c6d28..2ed4564ae99d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -119,6 +119,7 @@ properties:
> - starfive,jh7110-dwmac
> - tesla,fsd-ethqos
> - thead,th1520-gmac
> + - ultrarisc,dp1000-gmac
>
> reg:
> minItems: 1
>
> --
> 2.34.1
>
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20260824/5004b7f1/attachment.sig>
More information about the linux-riscv
mailing list