[PATCH bpf-next v2 1/2] bpf, riscv: Add support for signed arena loads
Chen Pei
cp0613 at linux.alibaba.com
Wed Aug 19 05:06:29 PDT 2026
Hi,
On 2026/8/19 17:37, bot+bpf-ci at kernel.org wrote:
> This isn't a bug, but would the comment fit the surrounding style
> better as an expression? The neighbouring case-group comments all
> spell the access out in pseudo-code form:
>
> /* LDX: dst = *(unsigned size *)(src + off) */
> /* LDSX: dst = *(signed size *)(src + off) */
> /* LDX | PROBE_MEM32: dst = *(unsigned size *)(src + RV_REG_ARENA + off) */
> /* ST | PROBE_MEM32: *(size *)(dst + RV_REG_ARENA + off) = imm */
> /* STX | PROBE_MEM32: *(size *)(dst + RV_REG_ARENA + off) = src */
>
> Something like this would match the pattern:
>
> /* LDX | PROBE_MEM32SX: dst = *(signed size *)(src + RV_REG_ARENA + off) */
Agreed, consistency with the neighbouring comments is more valuable
here. The pseudo-code form will be restored in v3.
Best regards,
Pei
More information about the linux-riscv
mailing list