[PATCH v1 5/5] riscv: dts: microchip: add a device tree for Discovery Kit

Conor Dooley conor at kernel.org
Tue Sep 2 01:31:55 PDT 2025


On Tue, Sep 02, 2025 at 08:22:02AM +0200, Krzysztof Kozlowski wrote:

> >>> +     refclk_ccc: cccrefclk {
> >>
> >> Please use name for all fixed clocks which matches current format
> >> recommendation: 'clock-<freq>' (see also the pattern in the binding for
> >> any other options).
> >>
> >> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > The fabric dtsi describes elements configured by the FPGA bitstream. 
> > This node is named as such because the Clock Conditioner Circuit CCC's 
> > reference clock source is set by the FPGA bitstream, while its frequency 
> > is determined by an on-board oscillator.
> > 
> > Hope this clarifies the rationale behind the node name.
> No, because there is no style naming clocks like this. Neither proper
> suffix, nor prefix. Use standard naming.

So you want all fixed frequency clocks to be named "clk-foo" when
"clk-<freq>" is not suitable? Fine if you do, but I didn't realise that
it was required and haven't been keeping an eye out for it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20250902/b61b3bbe/attachment.sig>


More information about the linux-riscv mailing list