[PATCH v2 2/2] ASoC: spacemit: add i2s support for K1 SoC

[Troy Mitchell]

On Thu, Aug 28, 2025 at 11:04:19AM +0200, Mark Brown wrote:
> On Thu, Aug 28, 2025 at 11:37:33AM +0800, Troy Mitchell wrote:
> 
> > +	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> > +	case SND_SOC_DAIFMT_DSP_A:
> > +	case SND_SOC_DAIFMT_DSP_B:
> > +		cpu_dai->driver->playback.channels_min = 1;
> > +		cpu_dai->driver->playback.channels_max = 1;
> 
> > +	if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_DSP_A)
> > +		sspsp_val |= SSPSP_FSRT;
> 
> It's weird and confusing that this isn't part of the above switch case.
Thanks! I'll change it.
> 
> > +static void spacemit_i2s_remove(struct platform_device *pdev)
> > +{
> > +	/* resources auto-freed by devm_ */
> > +}
> 
> If this can be empty remove it.
Yes, I will remove it in the next version.

Best regards,
Troy