[PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets
Krzysztof Kozlowski
krzk at kernel.org
Thu Nov 20 00:13:51 PST 2025
On Wed, Nov 19, 2025 at 07:46:43PM +0800, Encrow Thorne wrote:
> Add optional reset property for the SpacemiT K1 I2C.
Why? You just repeated diff and we can read the diff. Please explain WHY
you are doing things in terms of hardware.
>
> Signed-off-by: Encrow Thorne <jyc0019 at gmail.com>
> ---
> Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> index b7220fff2235..3d4faec41abe 100644
> --- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> @@ -27,6 +27,9 @@ properties:
> - description: I2C Functional Clock
> - description: APB Bus Clock
>
> + resets:
> + maxItems: 1
> +
Completely misplaced. There are never random properties between xxx and
xxx-names.
Best regards,
Krzysztof
More information about the linux-riscv
mailing list