[PATCH 3/4] riscv: dts: spacemit: add Gigabit Ethernet and PDMA to OrangePi R2S

Krzysztof Kozlowski krzk at kernel.org
Mon Nov 10 00:04:18 PST 2025


On Sun, Nov 09, 2025 at 10:30:09PM +0000, michael.opdenacker at rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker at rootcommit.com>
> 
> The OrangePi R2S board includes two RGMII ethernet ports
> supporting Gigabit Ethernet operation.
> 
> They have an external Motorcomm YT8531C PHY attached,
> the PHY uses GPIO for reset pin control. Their description
> was reused from the DTS from the OrangePi RV2 board.
> 
> Enable PDMA for the SpacemiT K1-based SoC.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker at rootcommit.com>
> 
> ---
> 

Squash the patch. You just added this board. Adding board is one commit.
Why adding incomplete or even buggy code just to fix it immediately?

Best regards,
Krzysztof

Best regards,
Krzysztof




More information about the linux-riscv mailing list