[PATCH v22 10/28] riscv/mm: Implement map_shadow_stack() syscall
Maciej W. Rozycki
macro at orcam.me.uk
Sun Nov 2 15:51:12 PST 2025
On Fri, 31 Oct 2025, Paul Walmsley wrote:
> This patch introduces a 'checkpatch.pl --strict' message:
>
> CHECK: Lines should not end with a '('
> #78: FILE: arch/riscv/kernel/usercfi.c:36:
> + asm goto(
>
> I'll fix it up here in the event that v22 goes in, but please do the same
> on your side in case a new version is needed.
I think this warning is silly for `asm' statements. It's been common for
decades to do this to format multi-line `asm' statements, just because it
makes them so much more readable. We have roughly two thousand instances
in our tree already and I would use this style for new code in the parts I
maintain as well.
Now having trailing `);' on a separate line is another matter.
Maciej
More information about the linux-riscv
mailing list