[PATCH v4 04/23] RISC-V: Add defines for the SBI message proxy extension

[Andy Shevchenko]

On Sun, May 25, 2025 at 02:16:51PM +0530, Anup Patel wrote:
> Add defines for the new SBI message proxy extension which is part
> of the SBI v3.0 specification.

...

> +/** RPMI message protocol specific MPXY attributes */

If you do a kernel-doc, do it properly.

> +enum sbi_mpxy_rpmi_attribute_id {
> +	SBI_MPXY_RPMI_ATTR_SERVICEGROUP_ID = SBI_MPXY_ATTR_MSGPROTO_ATTR_START,
> +	SBI_MPXY_RPMI_ATTR_SERVICEGROUP_VERSION,

> +	SBI_MPXY_RPMI_ATTR_MAX_ID,

Remove trailing comma for the terminator.

> +};
> +
> +/* Encoding of MSG_PROT_VER attribute */
> +#define SBI_MPXY_MSG_PROT_VER_MAJOR(__ver)	(((__ver) >> 16) & 0xffff)
> +#define SBI_MPXY_MSG_PROT_VER_MINOR(__ver)	((__ver) & 0xffff)

This can utilise GENAMSK() or even upper_16_bits()/lower_16_bits().

-- 
With Best Regards,
Andy Shevchenko