[PATCH v3 4/6] riscv: dts: spacemit: add pwm14_1 pinctrl setting

Guodong Xu guodong at riscstar.com
Mon May 26 19:48:18 PDT 2025


On Tue, May 27, 2025 at 5:52 AM Yixun Lan <dlan at gentoo.org> wrote:
>
> Hi Guodong, Uwe,
>
> On 18:54 Mon 26 May     , Uwe Kleine-König wrote:
> > On Tue, Apr 29, 2025 at 04:50:46PM +0800, Guodong Xu wrote:
> > > diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > index 283663647a86..195eb8874f3c 100644
> > > --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > @@ -20,4 +20,11 @@ uart0-2-pins {
> > >                     drive-strength = <32>;
> > >             };
> > >     };
> > > +   pwm14_1_cfg: pwm14-1-cfg {
> > > +           pwm14-1-pins {
> > > +                   pinmux = <K1_PADCONF(44, 4)>;
> > > +                   bias-pull-up = <0>;
> > > +                   drive-strength = <32>;
> > > +           };
> > > +   };
> >
> > There is a newline expected before the pwm14-1-cfg node, isn't there?
> >
> Right, I could amend this and fix it while applying this patch
> (so if there is no other serious issue, no need to resend)
>

Thanks, Yixun.

By the way, do you plan to take patches 3 and 4 of this series into
your tree? They only apply if the SpacemiT reset patchset is applied
first.

BR,
Guodong

> --
> Yixun Lan (dlan)



More information about the linux-riscv mailing list