[PATCH] dt-bindings: power: Add SiFive Domain Management controllers

[Nick Hu]

On Sat, May 10, 2025 at 10:57 PM Krzysztof Kozlowski <krzk at kernel.org> wrote:
>
> On 09/05/2025 17:57, Conor Dooley wrote:
> >>> +          - pattern: "^sifive,[ts]mc1$"
> >>> +      - items:
> >>> +          - {}
> >>> +          - const: sifive,cmc3
> >>> +          - const: sifive,cmc2
> >>> +      - items:
> >>> +          - {}
> >>> +          - const: sifive,cmc2
> >>
> >> All of this is just unexpected. Why any compatible should come with
> >> these?
> >
> > It's also not quite correct either, right? Or may not be correct at
> > least. It permits "xxx", "tmc2", "smc1" and "xxx", "smc2", "tmc1"
> > which mean that the smc and tmc must be identical in terms of
> > programming model.
>
> Yep
>
> >
> >> You need to use SoC specific compatibles.
> >
> > I think there's some slack to provide here, sifive are upstreaming it in
> > advance of there being customers (or customers ready to upstream) and this
> > format allows us to accept bindings/drivers and the customer will have
> > to add a soc-specific compatible in order to actually use these in a
> > dts. I think it's better to accept something along these lines than
>
> Sure, commit msg should explain that and probably these {} wildcards
> should have comment as well.
>
I'll update it in the next version. Thanks.

> > stall out until a customer decides to upstream their user. That said, I
> > would expect this to come (as you mentioned above) with the driver.
> >
>
> Best regards,
> Krzysztof