[PATCH v2 1/2] serial: sifive: lock port in startup()/shutdown() callbacks
Ryo Takakura
ryotkkr98 at gmail.com
Sun Mar 30 03:51:35 PDT 2025
Hi Greg,
On Sun, 30 Mar 2025 09:30:27 +0200, Greg KH wrote:
>On Sun, Mar 30, 2025 at 10:16:10AM +0900, Ryo Takakura wrote:
>> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
>> The register is also accessed from write() callback.
>>
>> If console were printing and startup()/shutdown() callback
>> gets called, its access to the register could be overwritten.
>>
>> Add port->lock to startup()/shutdown() callbacks to make sure
>> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
>> write() callback.
>>
>> Signed-off-by: Ryo Takakura <ryotkkr98 at gmail.com>
>> Cc: stable at vger.kernel.org
>> ---
>>
>> Hi,
>>
>> I'm sorry that I wasn't aware of how Cc stable should be done.
>>
>> I added Cc for stable but please tell me if this patch should be
>> resent or if there is any that is missing.
>
>Please resend a v3.
Ok. I'll send v3 shortly ;)
Sincerely,
Ryo Takakura
>thanks,
>
>greg k-h
More information about the linux-riscv
mailing list