[PATCH 04/12] irqchip/imx-mu-msi: Convert to msi_create_parent_irq_domain() helper

Frank Li Frank.li at nxp.com
Thu Jun 26 09:08:04 PDT 2025


On Thu, Jun 26, 2025 at 04:49:01PM +0200, Nam Cao wrote:
> From: Marc Zyngier <maz at kernel.org>
>
> Now that we have a concise helper to create an MSI parent domain,
> switch the IMX letter soup over to that.
>
> Signed-off-by: Marc Zyngier <maz at kernel.org>
> Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
> Link: https://lore.kernel.org/all/20241204124549.607054-7-maz@kernel.org

Reviewed-by: Frank Li <Frank.Li at nxp.com>

> ---
> Cc: Shawn Guo <shawnguo at kernel.org>
> Cc: Sascha Hauer <s.hauer at pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel at pengutronix.de>
> Cc: Fabio Estevam <festevam at gmail.com>
> Cc: imx at lists.linux.dev
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  drivers/irqchip/irq-imx-mu-msi.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/irqchip/irq-imx-mu-msi.c b/drivers/irqchip/irq-imx-mu-msi.c
> index 137da1927d144..d2a4e8a61a42b 100644
> --- a/drivers/irqchip/irq-imx-mu-msi.c
> +++ b/drivers/irqchip/irq-imx-mu-msi.c
> @@ -223,21 +223,21 @@ static const struct msi_parent_ops imx_mu_msi_parent_ops = {
>
>  static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *dev)
>  {
> -	struct fwnode_handle *fwnodes = dev_fwnode(dev);
> +	struct irq_domain_info info = {
> +		.ops		= &imx_mu_msi_domain_ops,
> +		.fwnode		= dev_fwnode(dev),
> +		.size		= IMX_MU_CHANS,
> +		.host_data	= msi_data,
> +	};
>  	struct irq_domain *parent;
>
>  	/* Initialize MSI domain parent */
> -	parent = irq_domain_create_linear(fwnodes, IMX_MU_CHANS,
> -					  &imx_mu_msi_domain_ops, msi_data);
> +	parent = msi_create_parent_irq_domain(&info, &imx_mu_msi_parent_ops);
>  	if (!parent) {
>  		dev_err(dev, "failed to create IRQ domain\n");
>  		return -ENOMEM;
>  	}
> -
> -	irq_domain_update_bus_token(parent, DOMAIN_BUS_NEXUS);
>  	parent->dev = parent->pm_dev = dev;
> -	parent->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT;
> -	parent->msi_parent_ops = &imx_mu_msi_parent_ops;
>  	return 0;
>  }
>
> --
> 2.39.5
>



More information about the linux-riscv mailing list