[PATCH 2/6] mfd: spacemit: add support for SpacemiT PMICs
Alex Elder
elder at riscstar.com
Thu Jun 19 06:23:26 PDT 2025
On 6/19/25 12:46 AM, Vivian Wang wrote:
> On 6/14/25 05:01, Alex Elder wrote:
>> <snip>
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 6fb3768e3d71c..c59ae6cc2dd8d 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -1182,6 +1182,17 @@ config MFD_QCOM_RPM
>> Say M here if you want to include support for the Qualcomm RPM as a
>> module. This will build a module called "qcom_rpm".
>>
>> +config MFD_SPACEMIT_PMIC
>> + tristate "SpacemiT PMIC"
>> + depends on ARCH_SPACEMIT || COMPILE_TEST
>> + depends on I2C && OF
>> + select MFD_CORE
>> + select REGMAP_I2C
>> + default ARCH_SPACEMIT
>> + help
>> + This option enables support for SpacemiT I2C based PMICs. At
>> + this time only the P1 PMIC (used with the K1 SoC) is supported.
>> +
>
> Module name?
>
> + To compile this driver as a module, choose M here: the
> + module will be called spacemit-pmic.
I will add a comment like this to the help text.
>
>> config MFD_SPMI_PMIC
>> tristate "Qualcomm SPMI PMICs"
>> depends on ARCH_QCOM || COMPILE_TEST
>>
>> <snip>
>>
>> +static struct i2c_driver spacemit_pmic_i2c_driver = {
>> + .driver = {
>> + .name = "spacemit-pmic",
>> + .of_match_table = spacemit_pmic_match,
>> + },
>> + .probe = spacemit_pmic_probe,
>> +};
>> +
>> +static int __init spacemit_pmic_init(void)
>> +{
>> + return i2c_add_driver(&spacemit_pmic_i2c_driver);
>> +}
>> +
>> +static void __exit spacemit_pmic_exit(void)
>> +{
>> + i2c_del_driver(&spacemit_pmic_i2c_driver);
>> +}
>> +
>> +module_init(spacemit_pmic_init);
>> +module_exit(spacemit_pmic_exit);
>> +
>
> module_i2c_driver
You're right. Thanks for the review. I also added
MODULE_ALIAS() for this driver, and defined MOD_NAME.
-Alex
>
> Regards,
> Vivian "dramforever" Wang
>
>> +MODULE_LICENSE("GPL");
>> +MODULE_DESCRIPTION("SpacemiT multi-function PMIC driver");
>
More information about the linux-riscv
mailing list