[PATCH v3 1/8] dt-bindings: power: Add T-HEAD TH1520 GPU power sequencer
Bartosz Golaszewski
brgl at bgdev.pl
Tue Jun 3 07:49:18 PDT 2025
On Tue, Jun 3, 2025 at 3:35 PM Bartosz Golaszewski <brgl at bgdev.pl> wrote:
> > >
> > > The compatible string could be updated like so:
> > > "thead,th1520-aon-pwrseq"
> >
> > Should not be separate node, you already have one for AON.
> >
>
> Agreed. And as far as implementation goes, you can have the same
> driver be a PM domain AND pwrseq provider. It just has to bind to the
> device node that represents an actual component, not a made-up
> "convenience" node.
>
I'm seeing that there's already a main driver under
drivers/pmdomain/thead/th1520-pm-domains.c and a "logical sub-driver"
under drivers/firmware/thead,th1520-aon.c which exposes
th1520_aon_init() called by the former. Maybe just follow that
pattern, add a module under drivers/power/sequencing/ called
pwrseq-th1520-pwrseq.c and call its init function from the pm-domains
module?
Bart
More information about the linux-riscv
mailing list