[PATCH] rseq/selftests: Fix riscv rseq_offset_deref_addv inline asm
Shuah Khan
skhan at linuxfoundation.org
Mon Jan 13 14:59:24 PST 2025
On 1/10/25 09:22, Mathieu Desnoyers wrote:
> On 2025-01-02 23:03, Stafford Horne wrote:
>> When working on OpenRISC support for restartable sequences I noticed
>> and fixed these two issues with the riscv support bits.
>>
>> 1 The 'inc' argument to RSEQ_ASM_OP_R_DEREF_ADDV was being implicitly
>> passed to the macro. Fix this by adding 'inc' to the list of macro
>> arguments.
>> 2 The inline asm input constraints for 'inc' and 'off' use "er", The
>> riscv gcc port does not have an "e" constraint, this looks to be
>> copied from the x86 port. Fix this by just using an "r" constraint.
>>
>> I have compile tested this only for riscv. However, the same fixes I
>> use in the OpenRISC rseq selftests and everything passes with no issues.
>>
>> Signed-off-by: Stafford Horne <shorne at gmail.com>
>
> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>
If these are going through risc repo
Acked-by: Shuah Khan <skhan at linuxfoundation.org>
If you would like me to take this, let me know.
thanks,
-- Shuah
More information about the linux-riscv
mailing list