[PATCH 03/10] arm64: dts: sophgo: Add initial SG2000 SoC device tree
Alexander Sverdlin
alexander.sverdlin at gmail.com
Tue Feb 11 01:22:13 PST 2025
Hi Krzysztof!
On Tue, 2025-02-11 at 09:07 +0100, Krzysztof Kozlowski wrote:
> > > > +&clk {
> > > > + compatible = "sophgo,sg2000-clk";
> > >
> > >
> > > That's discouraged practice. If you need to define compatible, it means
> > > the block is not shared between designs and must not be in common DTSI.
> >
> > That doesn't come from my series, that's how original cv18xx.dtsi has been
>
> You can change the other file to match real hardware. But if original
> cv18xx.dtsi has incorrect or imprecise compatible, I wonder how does it
> work....
cv18xx.dtsi doesn't have any "compatible". They define it for every SoC individually.
So it's same MMIO window, different compatible. Looking into the driver I can tell
that even the register map is the same, but they expose (and pre-enable) different
subsets on different SoCs.
--
Alexander Sverdlin.
More information about the linux-riscv
mailing list