[PATCH 1/5] dt-bindings: phy: Add Canaan K230 USB2.0 PHY DT schema
Krzysztof Kozlowski
krzk at kernel.org
Mon Dec 29 23:36:06 PST 2025
On Tue, Dec 30, 2025 at 10:37:20AM +0800, Jiayu Du wrote:
> k230-usb-phy driver supports USB 2.0 phys integrated in Canaan
Describe hardware, not driver.
> K230 SoC. Add YAML schema for its binding.
There is no such stuff as YAML schema for a binding. Look at other
commits how they phrase it.
>
> Signed-off-by: Jiayu Du <jiayu.riscv at isrc.iscas.ac.cn>
> ---
> .../bindings/phy/canaan,k230-usb-phy.yaml | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/canaan,k230-usb-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/canaan,k230-usb-phy.yaml b/Documentation/devicetree/bindings/phy/canaan,k230-usb-phy.yaml
> new file mode 100644
> index 000000000000..f1c9511c873f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/canaan,k230-usb-phy.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/canaan,k230-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Canaan K230 USB2.0 PHY
> +
> +maintainers:
> + - Jiayu Du <jiayu.riscv at isrc.iscas.ac.cn>
> +
> +properties:
> + compatible:
> + const: canaan,k230-usb-phy
> +
> + reg:
> + description:
> + Two register regions for USB PHY in HiSysConfig syscon block.
Drop
> + items:
> + - description: USB PHY test control reg (pullup/pulldown config)
> + - description: USB PHY core control reg (PLL/transceiver tuning)
> + minItems: 2
> + maxItems: 2
You didn't ever test it, did you? Drop last two lines.
> +
> + clocks:
> + maxItems: 1
> +
> + "#phy-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
clocks
> + - "#phy-cells"
> +
> +additionalProperties: false
Missing example.
> --
> 2.52.0
>
More information about the linux-riscv
mailing list