[PATCH v2 3/3] reset: spacemit: fix auxiliary device id
Alex Elder
elder at riscstar.com
Mon Dec 29 16:50:17 PST 2025
On 12/26/25 12:55 AM, Yixun Lan wrote:
> Due to the auxiliary register procedure moved to ccu common module,
> the auxiliary device id need to be adjusted, otherwise reset driver
> will fail to probe.
>
> Signed-off-by: Yixun Lan <dlan at gentoo.org>
> ---
> drivers/reset/reset-spacemit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-spacemit.c b/drivers/reset/reset-spacemit.c
> index e1272aff28f7..8922e14fa836 100644
> --- a/drivers/reset/reset-spacemit.c
> +++ b/drivers/reset/reset-spacemit.c
> @@ -278,7 +278,7 @@ static int spacemit_reset_probe(struct auxiliary_device *adev,
>
> #define K1_AUX_DEV_ID(_unit) \
> { \
> - .name = "spacemit_ccu_k1." #_unit "-reset", \
> + .name = "spacemit_ccu." _K_RST(_unit), \
> .driver_data = (kernel_ulong_t)&k1_ ## _unit ## _reset_data, \
> }
The above macro is named K1_AUX_DEV_ID(). Why don't you
define K3_AUX_DEV_ID(), which could use "k3" in its name?
Anyway, if you go this route I suggest you drop "K1_" from the
name of this macro.
-Alex
>
>
More information about the linux-riscv
mailing list