[PATCH v5 3/3] i2c: spacemit: drop warning when clock-frequency property is absent
Troy Mitchell
troy.mitchell at linux.spacemit.com
Sun Dec 28 17:20:57 PST 2025
On Sun, Dec 28, 2025 at 06:56:38PM -0600, Alex Elder wrote:
> On 12/26/25 2:32 AM, Troy Mitchell wrote:
> > The clock-frequency property is optional according to the DT binding.
> > Do not emit a warning when the property is missing and fall back to the
> > default frequency instead.
> >
> > Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> > Suggested-by: Alex Elder <elder at riscstar.com>
> > Signed-off-by: Troy Mitchell <troy.mitchell at linux.spacemit.com>
>
> Any error reading the "clock-frequency" property will simply leave
> i2c->clock_freq alone. This is good.
>
> But the lines that follow this issue a warning if i2c->clock_freq
> is 0. If it's optional, you should simply use a default value,
> and although you could state that rate with dev_info(), you should
> not warn about it.
Thanks! I get your point!
- Troy
More information about the linux-riscv
mailing list