[PATCH 2/2] riscv: dts: spacemit: Add MMC support on BPI-F3 and OrangePi RV2
Chukun Pan
amadeus at jmu.edu.cn
Wed Dec 24 07:00:03 PST 2025
Hi,
> +&sdhci0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc1_cfg>;
It would be better to arrange them in alphabetical order.
(Place pinctrl below no-sdio)
> + bus-width = <4>;
> + cd-gpios = <&gpio K1_GPIO(80) GPIO_ACTIVE_HIGH>;
It seems that "cap-sd-highspeed" is missing?
> + cd-inverted;
> + no-sdio;
> + status = "okay";
> +};
> + sdhci0: mmc at d4280000 {
An immature idea. Would naming nodes this way be better?
sdmmc: mmc at d4280000
sdio: mmc at d4280800
emmc: mmc at d4281000
This seems to fit the description here better:
https://bianbu-linux.spacemit.com/en/device/peripheral_driver/SDHC/#dts-configuration
Thanks,
Chukun
More information about the linux-riscv
mailing list