[PATCH v2] clk: spacemit: Fix module build for spacemit common ccu driver

[Yixun Lan]

Hi Inochi,

On 08:33 Wed 17 Dec     , Inochi Amaoto wrote:
> On Wed, Dec 17, 2025 at 08:18:33AM +0800, Yixun Lan wrote:
> > Hi Inochi, 
> > 
..
> > > +MODULE_IMPORT_NS("SPACEMIT_CCU");
> > the name should be ok as long as no collision and unique, but..
> > I personally would prefer "CLK_SPACEMIT" which follow "subsytem + vendor"
> > 
> 
> I disagree with you, after doing a grep, I found it is more common to
> use "vendor + xxx" format.
> 
I do not have strong preference, as I said on condition that it's unique,
and I do see Allwinner driver using "SUNXI_CCU" (driver/clk/sunxi-ng)

so if clock maintainer have no objection and don't want any enforcement,
then it would be fine by me

> 
> > > +MODULE_LICENSE("GPL");
> > I've got a comment [1] from Ziyao in the review of K3 clock driver
> > that suggest to distill the common probe function, which make sense.
> > So, I plan to have separated ccu_common.c file, with this change,
> > it would be more proper to put MODULE_DESCRIPTION/MODULE_LICENSE
> > into that file
> > 
> > It might takes some time to get there, as I now got a weird panic/hang
> > issue with that change..
> > 
> > Link: https://lore.kernel.org/all/aTo8sCPpVM1o9PKX@pie/ [1]
> > 
> 
> I have seen the K3 driver, but I think it is still necessary to add
> this line to this file. As this is a fix and it may be ported to the
> other version if got merged. So it is better to just add these line
> in the  ccu_pll.c and then you can move them in the file you desired.
> 
fair, let's push this first, then I'll try to refactor on top of it

thanks
-- 
Yixun Lan (dlan)