[PATCH] clk: spacemit: Fix module build for spacemit common ccu driver

Inochi Amaoto inochiama at gmail.com
Tue Dec 16 14:47:00 PST 2025


On Tue, Dec 16, 2025 at 10:48:45PM +0800, Yixun Lan wrote:
> Hi
> 
> On 06:12 Tue 16 Dec     , Yixun Lan wrote:
> > Hi Inochi,
> > 
> > On 07:29 Mon 15 Dec     , Inochi Amaoto wrote:
> > > For build spacemit common clock driver as a module, the build
> > > process require MODULE_LICENSE()/MODULE_DESCRIPTION() globally
> > > and EXPORT_SYMBOL() for every exposed symbol. Otherwise, the
> > > build will fail.
> > > 
> > > Add these missing hints, so the driver can be built as a module.
> > > 
> > > Fixes: 1b72c59db0ad ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
> > > Signed-off-by: Inochi Amaoto <inochiama at gmail.com>
> > looks good, thanks
> > 
> > Reviewed-by: Yixun Lan <dlan at gentoo.org>
> > 
> On my second thought, since all functions only used in spacemit clock
> driver, how about using symbol namespaces? please refer the doc
> 
> https://www.kernel.org/doc/Documentation/kbuild/namespaces.rst
> 
> or check drivers/clk/meson/ for example..
> 
> -- 
> Yixun Lan (dlan)

Good to know, I will change this in the v2.

Regards,
Inochi



More information about the linux-riscv mailing list