[PATCH 2/3] clk: sophgo: Add support for newly added precise compatible
Inochi Amaoto
inochiama at gmail.com
Wed Apr 30 15:42:31 PDT 2025
On Wed, Apr 30, 2025 at 04:33:39PM +0100, Conor Dooley wrote:
> On Wed, Apr 30, 2025 at 10:09:30AM +0800, Inochi Amaoto wrote:
> > Add of device id definition for newly added precise compatible.
> >
> > Signed-off-by: Inochi Amaoto <inochiama at gmail.com>
> > ---
> > drivers/clk/sophgo/clk-cv1800.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/clk/sophgo/clk-cv1800.c b/drivers/clk/sophgo/clk-cv1800.c
> > index e0c4dc347579..e10221df6385 100644
> > --- a/drivers/clk/sophgo/clk-cv1800.c
> > +++ b/drivers/clk/sophgo/clk-cv1800.c
> > @@ -1519,8 +1519,11 @@ static int cv1800_clk_probe(struct platform_device *pdev)
> >
> > static const struct of_device_id cv1800_clk_ids[] = {
> > { .compatible = "sophgo,cv1800-clk", .data = &cv1800_desc },
> > + { .compatible = "sophgo,cv1800b-clk", .data = &cv1800_desc },
>
> Given the same data is used here, should there not be fallbacks in the
> dt for some of these? For example, 1812 to 1800?
In default, there maybe not fallback for the whole series, I think.
But it is possible to use cv1800b as
> Or is that not okay, because 1800 is not a real device id?
Yes, cv1800-clk and cv1810-clk is a old wildcard compatible, not a
real one. As this is not prefered, I want to fix this to have a
meaningful compatible.
Regards,
Inochi
More information about the linux-riscv
mailing list