[PATCH v2 3/6] riscv: dts: spacemit: add PWM support for K1 SoC

[Guodong Xu]

On Tue, Apr 29, 2025 at 12:32 AM Uwe Kleine-König <ukleinek at kernel.org> wrote:
>
> Hello,
>
> On Mon, Apr 28, 2025 at 08:46:50PM +0800, Guodong Xu wrote:
> > On Thu, Apr 24, 2025 at 4:18 PM Uwe Kleine-König <ukleinek at kernel.org> wrote:
> > > I want to make all pwms use #pwm-cells = <3> in the long run. Can you
> >
> > Sure. I can do this.
> >
> > > please use that for the new binding? (Of course this needs adaption in
> > > the binding doc, the code should already be prepared for that.)
> > >
> >
> > I got what you mean. The code change for that is already integrated into
> > v6.15-rc1.
> > Commit 895fe4537cc8 ("pwm: Add upgrade path to #pwm-cells = <3> for users of
> > of_pwm_single_xlate()")
> >
> > Now, if I change this #pwm-cells from <1> to <3>, without the dt-binding doc
> > changes, I would expect to see warnings (" #pwm-cells: 1 was expected") during
> >   make dtbs_check W=3
> >
> > Any suggestions when the dt-binding changes will be merged?
> > or I can add your patch as a dependency.
> > https://lore.kernel.org/all/cb799d8a5bb284cd861785a691b8d5e329300d99.1738842938.git.u.kleine-koenig@baylibre.com/
>
> I don't want to merge this very soon given that 895fe4537cc8 isn't that
> old yet. But I suggest you adapt patch #1 to require #pwm-cells = <3>
> for the newly added compatible.

ok, I will add a conditional check of #pwm-cells based on the compatible.
spacemit,k1-pwm must use 3; other compatibles use 1.
 (if:then:else in the bingding yaml)

Thanks.
Guodong

>
> Best regards
> Uwe