Re: [RFC PATCH 1/3] dt-bindings: pinctrl: jh7110-sys: add force inputs

[Icenowy Zheng]

于 2025年4月23日 GMT+08:00 17:09:42，Linus Walleij <linus.walleij at linaro.org> 写道：
>Hi Icenowy,
>
>thanks for your patch!
>
>On Tue, Apr 22, 2025 at 6:23 PM Icenowy Zheng <uwu at icenowy.me> wrote:
>
>> +  starfive,force-low-inputs:
>> +    description:
>> +      The list of input signals forced to be low inside the SoC itself.
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>
>I don't see why you need this hack.

Unfortunately these properties are not for pins, but internal signals that isn't
bound to external pins.

>
>Use the existing per-pin output-low property (see
>Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml).
>
>> +  starfive,force-high-inputs:
>> +    description:
>> +      The list of input signals forced to be high inside the SoC itself.
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>
>Use the existing output-high property.
>
>Now I *know* these two properties are per-pin. That is more talkative
>but way easier for users to read.
>
>Then use pincontrol hogs to make sure these configs are set up
>at probe.
>
>Yours,
>Linus Walleij