[PATCH v3] riscv: KGDB: Do not inline arch_kgdb_breakpoint()

WangYuli wangyuli at uniontech.com
Thu Apr 10 07:28:39 PDT 2025


Hi Alex

On 2025/4/10 21:42, Alexandre Ghiti wrote:
> Hi WangYuli,
>
>
> You forgot to replace kgdb_breakinst into kgdb_compiled_break.

OK, I'll fix it.

Thanks,

>
> You are fixing 2 things here, you need to split this patch into 2. 
OK,
> And as noted by Palmer, we actually don't need norvc here, so you can 
> remove it instead.

I have some questions regarding this.

If .option norvc is unnecessary, what is the significance of .option 
push/.option pop?

Should they also be removed as well?

However, will this still function properly when the RISC-V C extension 
is active?


Thanks,

-- 
WangYuli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xC5DA1F3046F40BEE.asc
Type: application/pgp-keys
Size: 632 bytes
Desc: OpenPGP public key
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20250410/22155d47/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20250410/22155d47/attachment.sig>


More information about the linux-riscv mailing list