[PATCH 1/2] dt-bindings: pwm: sophgo: add pwm controller for SG2044
Uwe Kleine-König
ukleinek at kernel.org
Mon Apr 7 05:31:24 PDT 2025
Hello,
On Mon, Apr 07, 2025 at 03:20:38PM +0800, Longbin Li wrote:
> diff --git a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml b/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
> index bbb6326d47d7..e0e91aa237ec 100644
> --- a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml
> @@ -17,7 +17,9 @@ allOf:
>
> properties:
> compatible:
> - const: sophgo,sg2042-pwm
> + enum:
> + - sophgo,sg2042-pwm
> + - sophgo,sg2044-pwm
Given that the sg2044 has more registers (to e.g. implement different
polarity), but the sg2042 registers are identical, I wonder if the 2044
device should use:
compatible = "sophgo,sg2044-pwm", "sophgo,sg2042-pwm";
Note, I'm unsure here, only providing input to people who are more
knowledgeable in DT that I am.
Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20250407/1dc7eb40/attachment.sig>
More information about the linux-riscv
mailing list