[PATCH] serial: sifive: lock port in startup()/shutdown() callbacks

Ryo Takakura ryotkkr98 at gmail.com
Sat Apr 5 07:28:32 PDT 2025


Hi Greg,

On Sat, 5 Apr 2025 14:40:33 +0100, Greg KH wrote:
>On Sat, Apr 05, 2025 at 10:24:58PM +0900, Ryo Takakura wrote:
>> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
>> The register is also accessed from write() callback.
>> 
>> If console were printing and startup()/shutdown() callback
>> gets called, its access to the register could be overwritten.
>> 
>> Add port->lock to startup()/shutdown() callbacks to make sure
>> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
>> write() callback.
>> 
>> Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART")
>> Signed-off-by: Ryo Takakura <ryotkkr98 at gmail.com>
>> Cc: stable at vger.kernel.org
>> ---
>> 
>> This patch used be part of a series for converting sifive driver to
>> nbcon[0]. It's now sent seperatly as the rest of the series does not
>> need be applied to the stable branch.
>
>That means this is a v2 patch, and you should also send the other patch
>as a v2 as well, right?

Oh yes. I wasn't sure about the versioning for this patch. Let me resend
this patch as v2.
Also for the other patch, as now its sent as a single standalone patch,
I'll resend it as v2.

>thanks,
>
>greg k-h



More information about the linux-riscv mailing list