[patch v2 3/3] riscv: dts: starfive: add framework dts

Conor Dooley conor at kernel.org
Tue Sep 24 09:26:18 PDT 2024


On Tue, Sep 24, 2024 at 11:55:44AM +0200, Rafał Miłecki wrote:
> On 2024-09-24 10:06, Sandie Cao wrote:
> > diff --git a/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > new file mode 100644
> > index 000000000000..ff12c24ebab3
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/*
> > + * Copyright (C) 2022 StarFive Technology Co., Ltd.
> > + * Copyright (C) 2022 Emil Renner Berthing <kernel at esmil.dk>
> > + */
> > +
> > +/dts-v1/;
> > +#include "jh7110-common.dtsi"
> > +
> > +/ {
> > +	model = "Framework FRANME0000";
> > +	compatible = "deepcomputing,fm7110", "starfive,jh7110";
> > +};
> 
> Nitpicking: property "compatible" should go first.
> 
> See Documentation/devicetree/bindings/dts-coding-style.rst

I think "model" usually goes before compatible, I wouldn't change it
here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20240924/49df641b/attachment.sig>


More information about the linux-riscv mailing list