[PATCH v9 2/7] iommu/riscv: Add RISC-V IOMMU platform device driver

[Tomasz Jeznach]

Hello Uwe,

On Wed, Oct 16, 2024 at 2:35 AM Uwe Kleine-König
<u.kleine-koenig at baylibre.com> wrote:
>
> Hello,
>
> On Thu, Oct 10, 2024 at 12:48:05PM -0700, Tomasz Jeznach wrote:
> > +static const struct of_device_id riscv_iommu_of_match[] = {
> > +     {.compatible = "riscv,iommu",},
>
> nitpick: Unusual indention:
>
> uwe at taurus:~/gsrc/linux$ git grep -l '{.compatible =' | wc -l
> 192
> uwe at taurus:~/gsrc/linux$ git grep -l '{ .compatible =' | wc -l
> 4197
>
> (Hu, I expected the difference to be bigger than a factor of ~20.)
>
> I'd go for a space before ".compatible" and one after the trailing
> comma.
>
> > +     {},
> > +};
> > +
> > +static struct platform_driver riscv_iommu_platform_driver = {
> > +     .probe = riscv_iommu_platform_probe,
> > +     .remove_new = riscv_iommu_platform_remove,
> > +     .driver = {
> > +             .name = "riscv,iommu",
> > +             .of_match_table = riscv_iommu_of_match,
> > +             .suppress_bind_attrs = true,
> > +     },
> > +};
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
>

Thank you for those comments, they look reasonable.
Can we postpone those changes after v10 is merged into the iommu subsystem tree?

> Best regards
> Uwe

Best regards,
- Tomasz