[PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc controllers

[Thomas Bonnefille]

On 5/2/24 5:53 PM, Drew Fustini wrote:
> On Thu, May 02, 2024 at 09:47:43AM +0200, Thomas Bonnefille wrote:
>>
>>
>> On 4/27/24 2:10 AM, Drew Fustini wrote:
>>> Change the clock property in the T-Head TH1520 mmc controller nodes to a
>>> real clock provided by the AP_SUBSYS clock driver.
>>>
>>> Signed-off-by: Drew Fustini <dfustini at tenstorrent.com>
>>
>> I experienced that, when the I2C clocks were correctly configured, the UART
>> stopped working, likely due to their dependence on FOUTPOSTDIV.
>> Setting up the UART correctly, for instance:
>>
>>                  uartx: serial at xxxxxxxxxx {
>> 			...
>>                          clocks = <&clk CLK_UART_SCLK>, <&clk
>> CLK_UARTX_PCLK>;
>>                          clock-names = "baudclk", "apb_pclk";
>>                          ...
>> 			status = "disabled";
>>                  };
>> resolved the issue.
>> As this would be mandatory in the future, I suggest that you configure all
>> the nodes currently set to a fixed clock, not just the MMC controller.
> 
> Thank you for testing and discovering this issue.
> 
> Could you post your device tree so I can be sure I'm testing the same as
> what you have?
> 
> Drew

Of course, I'll attach the two Device Trees used.
Note that I also use Emil's patch which adds support for pinctrl.

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: th1520.dtsi
Type: text/x-devicetree-source
Size: 14503 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20240503/04877355/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: th1520-beaglev-ahead.dts
Type: audio/vnd.dts
Size: 4484 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20240503/04877355/attachment.dts>