[PATCH 3/3] spi: spi-microchip-core: Fix the number of chip selects supported
Conor Dooley
conor at kernel.org
Thu May 2 08:47:32 PDT 2024
On Thu, May 02, 2024 at 03:34:10PM +0100, Prajna Rajendra Kumar wrote:
> The SPI controller in PolarFire SoC has multiple chip selects, but only
> one is wired up in the MSS. Therefore, fix the driver to chose one
> chip select.
Given Krzysztof's comments on the binding "only one is wired up in the
MSS" probably means nothing to anyone other than us, and we should
rephrase this so that we explain what this actually means.
The actual change is fine to me though, since I do understand what's
being said here. With a revised commit message:
Reviewed-by: Conor Dooley <conor.dooley at microchip.com>
Cheers,
Conor.
>
> Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")
> Signed-off-by: Prajna Rajendra Kumar <prajna.rajendrakumar at microchip.com>
> ---
> drivers/spi/spi-microchip-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
> index 71886c27bca3..4289dfba9af5 100644
> --- a/drivers/spi/spi-microchip-core.c
> +++ b/drivers/spi/spi-microchip-core.c
> @@ -21,7 +21,7 @@
> #include <linux/spi/spi.h>
>
> #define MAX_LEN (0xffff)
> -#define MAX_CS (8)
> +#define MAX_CS (1)
> #define DEFAULT_FRAMESIZE (8)
> #define FIFO_DEPTH (32)
> #define CLK_GEN_MODE1_MAX (255)
> --
> 2.25.1
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20240502/80c3b943/attachment.sig>
More information about the linux-riscv
mailing list