回复: [PATCH v9 2/3] clocksource: Add JH7110 timer driver

Ziv Xu ziv.xu at starfivetech.com
Tue Mar 19 18:40:31 PDT 2024



> On Mon, Mar 18, 2024 at 11:06:48AM +0800, Ziv Xu wrote:
> 
> > +static int jh7110_timer_start(struct jh7110_clkevt *clkevt) {
> > +	int ret;
> > +
> > +	/* Disable and clear interrupt first */
> > +	writel(JH7110_TIMER_INT_DIS, clkevt->base +
> JH7110_TIMER_INT_MASK);
> > +	ret = jh7110_timer_int_clear(clkevt);
> 
> The return value here is not checked/used.
> 
I will change it in the next version,thanks.

Best regards
Ziv.xu

> > +	writel(JH7110_TIMER_INT_ENA, clkevt->base +
> JH7110_TIMER_INT_MASK);
> > +	writel(JH7110_TIMER_ENA, clkevt->base + JH7110_TIMER_ENABLE);
> > +
> > +	return 0;
> > +}




More information about the linux-riscv mailing list