[PATCH 2/4] riscv: uaccess: use input constraints for ptr of __put_user
David Laight
David.Laight at ACULAB.COM
Fri Jun 28 08:36:17 PDT 2024
From: Arnd Bergmann
> Sent: 26 June 2024 15:25
...
> If you just copy from the arm64 version that uses an
> "r"(address) constraint instead of the "m"(*address)
> version, it should be fine for any user space access.
Arm certainly has 'reg+offset' addressing and I'd have thought
the RISC-V would have it as well.
I'd guess that the compiler also knows when the offset is too big.
Probably noticeable when code is accessing structures in user memory.
OTOH I can't remember if "m" implies a memory clobber?
For user copies the memory clobber isn't needed and not having it
may well allow better instruction scheduling.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
More information about the linux-riscv
mailing list