[PATCH v3 1/3] dt-bindings: i2c: dw: Document compatible thead,th1520-i2c

[Krzysztof Kozlowski]

On 19/06/2024 08:40, Jarkko Nikula wrote:
> Hi
> 
> On 6/18/24 10:42 AM, Thomas Bonnefille wrote:
>> Add documentation for compatible string thead,th1520-i2c which can be
>> used specifically for the TH1520 SoC.
>>
>> Signed-off-by: Thomas Bonnefille <thomas.bonnefille at bootlin.com>
>> Acked-by: Conor Dooley <conor.dooley at microchip.com>
>> ---
>>   Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>> index d9293c57f573..60035a787e5c 100644
>> --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>> +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>> @@ -33,6 +33,10 @@ properties:
>>             - const: snps,designware-i2c
>>         - description: Baikal-T1 SoC System I2C controller
>>           const: baikal,bt1-sys-i2c
>> +      - description: T-HEAD TH1520 SoCs I2C controller
>> +        items:
>> +          - const: thead,th1520-i2c
>> +          - const: snps,designware-i2c
>>   
> 
> Your comment below makes me thinking is this change needed? So is it 
> enough to specify "snps,designware-i2c" for the compatible string in 
> patch 2/3?

SoC specific compatible is always required (see writing bindings doc).

Best regards,
Krzysztof